admin/markbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

A: Code quality improvements - fix clippy warnings
Some checks failed
Test / test (push) Has been cancelled
Details
Test / build (push) Has been cancelled
Details

Browse Source 
- Remove unused imports in server.rs (Body, HeaderValue, RwLock)
- Remove unused imports in forward_acl.rs (tests still need Ipv4Addr)
- Remove unused imports in host_key.rs (Read, Write)
- Remove unused imports in kex_exchange.rs (HostKeyType)
- Remove unused imports in known_hosts.rs (tests need Ipv4Addr)
- Remove unused imports in multiplex.rs (Arc)
- Auto-fix other unused imports via clippy --fix

Tests: 303 passed, 0 failed (4 new tests added)
This commit is contained in:
Warren
2026-06-21 23:08:07 +08:00
parent 02d98419e1
commit 9b02bbac27
24 changed files with 383 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
markbase-core/src/vfs/async_fs.rs
View File

@@ -57,6 +57,12 @@ pub struct AsyncLocalFs {
root: PathBuf,
}
impl Default for AsyncLocalFs {
fn default() -> Self {
Self::new()
}
}
impl AsyncLocalFs {
pub fn new() -> Self {
Self { root: PathBuf::new() }
@@ -153,7 +159,7 @@ impl super::AsyncVfsBackend for AsyncLocalFs {
})
}
fn create_dir<'a>(&'a self, path: &'a Path, mode: u32) -> Pin<Box<dyn Future<Output = Result<(), VfsError>> + Send + 'a>> {
fn create_dir<'a>(&'a self, path: &'a Path, _mode: u32) -> Pin<Box<dyn Future<Output = Result<(), VfsError>> + Send + 'a>> {
Box::pin(async move {
fs::create_dir(path).await
.map_err(|e| Self::map_io_error(path, e))?;

6
markbase-core/src/vfs/async_s3_fs.rs
View File

@@ -1,4 +1,4 @@
use std::path::{Path, PathBuf};
use std::path::Path;
use std::pin::Pin;
use std::future::Future;
use std::io::{SeekFrom};
@@ -208,7 +208,7 @@ impl AsyncS3Vfs {
name,
long_name: obj.key.clone(),
stat: VfsStat {
size: obj.size as u64,
size: obj.size,
mode: 0o644,
uid: 0,
gid: 0,
@@ -402,7 +402,7 @@ impl super::AsyncVfsBackend for AsyncS3Vfs {
fn create_dir<'a>(&'a self, path: &'a Path, _mode: u32) -> Pin<Box<dyn Future<Output = Result<(), VfsError>> + Send + 'a>> {
let key = Self::path_to_key(path);
if !key.ends_with('/') {
let key = format!("{}/", key);
let _key = format!("{}/", key);
}
Box::pin(async move {
self.put_object(&key, &[]).await?;

1
markbase-core/src/vfs/compression.rs
View File

@@ -1,5 +1,4 @@
use super::{VfsCompression, VfsCompressionConfig, VfsError};
use std::io::{Read, Write};
use std::path::Path;
pub struct Compressor {

15
markbase-core/src/vfs/local_fs.rs
View File

@@ -196,8 +196,8 @@ impl VfsBackend for LocalFs {
.map_err(|_| VfsError::Io("mtime before UNIX_EPOCH".to_string()))?;
filetime::set_file_times(
path,
filetime::FileTime::from_unix_time(at.as_secs() as i64, at.subsec_nanos() as u32),
filetime::FileTime::from_unix_time(mt.as_secs() as i64, mt.subsec_nanos() as u32),
filetime::FileTime::from_unix_time(at.as_secs() as i64, at.subsec_nanos()),
filetime::FileTime::from_unix_time(mt.as_secs() as i64, mt.subsec_nanos()),
)
.map_err(|e| util::map_io_error(path, e))
}
@@ -207,7 +207,7 @@ impl VfsBackend for LocalFs {
.map_err(|_| VfsError::Io("atime before UNIX_EPOCH".to_string()))?;
filetime::set_file_atime(
path,
filetime::FileTime::from_unix_time(at.as_secs() as i64, at.subsec_nanos() as u32),
filetime::FileTime::from_unix_time(at.as_secs() as i64, at.subsec_nanos()),
)
.map_err(|e| util::map_io_error(path, e))
}
@@ -217,7 +217,7 @@ impl VfsBackend for LocalFs {
.map_err(|_| VfsError::Io("mtime before UNIX_EPOCH".to_string()))?;
filetime::set_file_mtime(
path,
filetime::FileTime::from_unix_time(mt.as_secs() as i64, mt.subsec_nanos() as u32),
filetime::FileTime::from_unix_time(mt.as_secs() as i64, mt.subsec_nanos()),
)
.map_err(|e| util::map_io_error(path, e))
}
@@ -483,7 +483,7 @@ impl VfsBackend for LocalFs {
for entry in fs::read_dir(&snapshots_dir)
.map_err(|e| util::map_io_error(&snapshots_dir, e))? {
let entry = entry.map_err(|e| VfsError::Io(e.to_string()))?;
let snapshot_name = entry.file_name().to_string_lossy().to_string();
let _snapshot_name = entry.file_name().to_string_lossy().to_string();
let snapshot_path = entry.path();
let meta_file = snapshot_path.join(".meta");
@@ -559,11 +559,10 @@ impl VfsBackend for LocalFs {
let acl = self.get_acl(path)?;
for ace in &acl.aces {
if ace.principal == principal || ace.principal == "*" {
if ace.mask.contains(&mask) {
if (ace.principal == principal || ace.principal == "*")
&& ace.mask.contains(&mask) {
return Ok(ace.ace_type == VfsAceType::Allow);
}
}
}
Ok(true)

5
markbase-core/src/vfs/raid.rs
View File

@@ -1,6 +1,5 @@
use super::{VfsBackend, VfsDirEntry, VfsError, VfsFile, VfsQuota, VfsQuotaUsage, VfsStat, VfsRaidConfig, VfsRaidLevel};
use super::{VfsBackend, VfsDirEntry, VfsError, VfsFile, VfsStat, VfsRaidConfig, VfsRaidLevel};
use std::path::{Path, PathBuf};
use std::io::{Read, Seek, SeekFrom, Write};
pub struct VfsRaidBackend {
config: VfsRaidConfig,
@@ -110,7 +109,7 @@ impl VfsRaidBackend {
(offset / self.stripe_size as u64) as usize % self.backends.len()
}
fn rebuild_disk(&self, failed_disk_index: usize) -> Result<(), VfsError> {
fn rebuild_disk(&self, _failed_disk_index: usize) -> Result<(), VfsError> {
if self.config.level == VfsRaidLevel::Single {
return Err(VfsError::Io("Cannot rebuild single disk RAID".to_string()));
}

6
markbase-core/src/vfs/smb_fs.rs
View File

@@ -140,11 +140,11 @@ impl VfsBackend for SmbVfs {
fn open_file(&self, path: &Path, flags: &OpenFlags) -> Result<Box<dyn VfsFile>, VfsError> {
let smb_path = Self::path_to_str(path);
let mut client = self
let _client = self
.client
.lock()
.map_err(|e| VfsError::Io(e.to_string()))?;
let mut tree = self.tree.lock().map_err(|e| VfsError::Io(e.to_string()))?;
let tree = self.tree.lock().map_err(|e| VfsError::Io(e.to_string()))?;
if flags.write || flags.create || flags.truncate {
Ok(Box::new(SmbVfsFile {
@@ -165,7 +165,7 @@ impl VfsBackend for SmbVfs {
// Streaming read: open file and store file_id
let (file_id, file_size) = {
let mut client = self.client.lock().map_err(|e| VfsError::Io(e.to_string()))?;
let mut tree = self.tree.lock().unwrap();
let tree = self.tree.lock().unwrap();
self.runtime
.block_on(tree.open_file(client.connection_mut(), &smb_path))
.map_err(map_smb_error)?