Commit Graph

1 Commits

Author SHA1 Message Date
Warren
70353d2a55 Phase 4: Critical issue analysis - SSH packet size exceeds maxpack
- Issue: SSH_FXP_DATA packet size 32786 bytes exceeds client maxpack 32768
- Root cause: handle_read() returns full requested data without maxpack limit
- Severity:  Critical (blocks all large file transfers)

OpenSSH reference:
- sftp-server.c: process_read() limits data to maxpacket - 1024
- MarkBaseSSH: No maxpack limit currently

Solution (Recommended):
- Add maxpack field to SftpHandler structure
- Limit handle_read() data size to maxpack - 1024 bytes
- Get maxpack from Channel.remote_maxpacket

Estimated work: ~50 lines, ~30 minutes testing
2026-06-17 20:10:53 +08:00