Warren
7b033e5276
Implement SMB streaming read using chunked READ requests
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
- Add file_id and read_chunk_size fields to SmbVfsFile
- Use Tree::open_file() to get file_id for reads
- Issue READ requests on each read() call (64KB chunks)
- Close file handle in Drop
Benefits:
- No memory overhead for large files
- Read-ahead caching possible
- Compatible with SMB2 protocol
All 229 tests pass.
2026-06-20 21:24:55 +08:00
Warren
c91dbe2cc3
Fix SSH cipher key length: dynamically determine based on negotiated algorithm
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
- Add cipher_key_len() helper function
- Store encryption_ctos/stoc in KexExchangeHandler
- Use algorithm name to determine key_len (aes256 → 32, aes128 → 16)
- Remove hardcoded cipher_key_len=32 TODO
All 229 tests pass.
2026-06-20 21:16:25 +08:00
Warren
914eacb230
Suppress non_snake_case warning for RFC 4253 notation (K, H, X)
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
2026-06-20 21:10:28 +08:00
Warren
dbca6e6d35
Fix clippy warnings: unused imports, minor style fixes
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
2026-06-20 21:08:50 +08:00
Warren
3986fb28fb
SMB CLI: Add S3 VFS backend support (--s3 flag)
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
Usage:
smb-start --s3 --s3-endpoint https://s3.example.com --s3-bucket mybucket --s3-access-key AKIA... --s3-secret-key secret...
All SMB operations now work over S3-compatible storage.
All 229 tests pass.
2026-06-20 20:49:22 +08:00
Warren
d1467f03bd
SMB CLI: Add multi-user support (--user name:password)
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
- Add --user CLI argument (repeatable) format: name:password
- Default user 'demo:demo123' if no users specified
- All users get ReadWrite access to the share
- Note: SMB3 encryption not available (smb-server v1 out of scope)
Example:
smb-start --user alice:pass1 --user bob:pass2 --share-name myshare
All 229 tests pass.
2026-06-20 20:44:23 +08:00
Warren
51ca0c4633
SMB VFS: Add set_len, set_stat, streaming write, auto_reconnect
...
Test / build (push) Has been cancelled
Test / test (push) Has been cancelled
- set_len() via SMB SET_INFO compound (CREATE → SET_INFO → CLOSE)
with FileEndOfFileInformation (class 14)
- set_stat() via SMB SET_INFO compound with FileBasicInformation (class 4)
for timestamp updates (atime, mtime)
- Streaming write using Tree::create_file_writer + FileWriter::write_chunk
+ finish for pipelined uploads
- Add file_writer: Option<FileWriter> to SmbVfsFile for streaming state
- Enable auto_reconnect by default (new_with_options param)
- Add systemtime_to_filetime helper for timestamp conversion
All 229 tests pass.
2026-06-20 20:26:35 +08:00
Warren
8a85c2ef7c
SMB comprehensive unit tests (229 passed, 0 failed)
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
smb_server_backend.rs tests (+135 lines):
- Full VfsHandle lifecycle: file create/write/read/flush/close, stat,
truncate (zero + extend), set_times, list_dir error, write past end
- Directory: create/stat/list/close, contains-created-file, read/write/truncate
error cases
- All OpenIntent variants: Create (new + existing fail), OpenOrCreate
(new + existing), OverwriteOrCreate (new + truncate existing), Truncate
(existing + nonexistent fail)
- Directory OpenIntent: Create (new + existing fail), Open (existing),
OpenOrCreate (new + existing)
- non_directory flag on dir (IsDirectory), directory flag on file (NotADirectory)
- Unlink: file, directory, nonexistent (NotFound)
- Rename: success + content preserved, nonexistent source (NotFound),
existing target (Exists)
- Error mapping: all 8 VfsError variants (adds Unsupported, UnexpectedEof)
- FILETIME: roundtrip, below-offset returns epoch, exactly-offset
- vfs_stat_to_file_info: custom name, dir name from path, alloc_size
smb_fs.rs tests (+40 lines):
- Error mapping: NotFound, AlreadyExists, AccessDenied, IsADirectory,
NotADirectory, DiskFull, SharingViolation, ConnectionLost, TimedOut,
SessionExpired, InvalidData, Auth, Io, Cancelled
- Filetime: conversion, below-epoch, exact epoch boundary
- Path: leading slash stripping, root, deep paths
- Rejects trailing backslash
2026-06-20 19:57:20 +08:00
Warren
7eb528d35f
SMB Server Phase 2: VFS backend build fix + integration test
...
Test / build (push) Has been cancelled
Test / test (push) Has been cancelled
- Add VfsFile: Send supertrait for Mutex compatibility
- Fix SmbServerCommand: struct → Subcommand enum with Start variant
- Fix tracing_subscriber::init() → try_init() to avoid panic when
logger already initialized
- Fix CLI subcommand name: smb-server → smb-start (flatten naming)
- Add #[command(name = "smb-start")] for CLI disambiguation
- Fix unused variable warnings (smb_fs.rs, smb_server_backend.rs)
- Remove unused VfsFile imports (webdav.rs, scp_handler.rs)
- Integration test: Docker smbclient verified (list, upload, read)
2026-06-20 19:42:29 +08:00
Warren
45d050c0b3
P0: exit-status for subsystem, improved error msgs, integration test suite
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
2026-06-20 16:40:29 +08:00
Warren
5b439dfbef
Phase 17: SCP over SFTP subsystem + EOF/CLOSE fixes
Test / build (push) Has been cancelled
Test / test (push) Has been cancelled
2026-06-20 16:31:00 +08:00
Warren
56217bc9a5
Fix exit-status: save exit code in ALL 3 try_wait() paths (not just timeout)
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
2026-06-20 16:11:58 +08:00
Warren
87f5afb9d3
Web Frontend Phase 3: add Upload tab to category_view.html
Test / build (push) Has been cancelled
Test / test (push) Has been cancelled
2026-06-20 16:05:56 +08:00
Warren
3ebc10f195
Remove dead code: compute_exchange_hash + write_ssh_mpint_to_hash in kex_complete.rs (replaced by kex_exchange.rs version)
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
2026-06-20 15:59:17 +08:00
Warren
8bcda75f83
Fix exit-status: send SSH_MSG_CHANNEL_REQUEST exit-status per RFC 4254 §6.10
Test / build (push) Has been cancelled
Test / test (push) Has been cancelled
2026-06-20 15:47:07 +08:00
Warren
e0e145e277
fix(ssh): Re-add uint32 prefix for shared secret K in exchange hash and key derivation
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
OpenSSH sshbuf_put_bignum2_bytes() writes uint32(len) + mpint_data
to the buffer (confirmed from sshbuf-getput-basic.c line 569). Both
kex_gen_hash() via sshbuf_putb() and kex_derive_keys() via
ssh_digest_update_buffer() consume the full buffer including the uint32
prefix.
Fixes 'incorrect signature' error on OpenSSH 10.2.
2026-06-20 15:41:43 +08:00
Warren
6ef1537c1b
fix(ssh): Add detailed MAC calculation logging for debugging
Test / build (push) Has been cancelled
Test / test (push) Has been cancelled
2026-06-20 14:13:17 +08:00
Warren
f124082d3d
fix(ssh): Change bind_address to 0.0.0.0 for Docker container access (Phase 8.3)
Test / build (push) Has been cancelled
Test / test (push) Has been cancelled
2026-06-20 13:43:12 +08:00
Warren
d5a9e95753
feat(ssh): Implement complete SCP file transfer state machine (Phase 8.3)
Test / build (push) Has been cancelled
Test / test (push) Has been cancelled
2026-06-20 12:54:55 +08:00
Warren
cc30a8e9b1
feat(ssh): Add ScpState state machine for SCP file transfer (Phase 8.3 init)
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
2026-06-20 12:53:25 +08:00
Warren
ac84489654
feat(ssh): Replace blocking handle_scp() with direct SCP protocol parsing (Phase 8.2)
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
2026-06-20 12:06:06 +08:00
Warren
fc6648e4fd
feat(ssh): Implement SCP protocol handling with ChannelReadWrite (Phase 8 complete)
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
2026-06-20 11:48:57 +08:00
Warren
ac17e1725c
feat(ssh): Add SCP subsystem packet processing framework (Phase 8 partial)
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
2026-06-20 11:32:55 +08:00
Warren
3e6acee2c5
feat(ssh): Add SCP subsystem initialization (Phase 8 partial)
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
2026-06-20 01:45:08 +08:00
Warren
62927825d5
feat(web): Add WebDAV endpoint to web server (Port 11438)
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
2026-06-20 01:14:55 +08:00
Warren
00767c1d26
perf(ssh): Remove ChaCha20-Poly1305 algorithm (AES-GCM already achieves 100 MB/s)
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
2026-06-19 23:36:47 +08:00
Warren
a4493b8528
perf(ssh): Phase 3 BufferPool - preallocate Vec in hot paths
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
Phase 3: Preallocate Vec with capacity to reduce allocations
channel.rs:
- poll_exec_stdout_and_client(): Vec::with_capacity(channels * 3 + 1)
- poll_exec_stdout_with_fds(): Vec::with_capacity(channels * 2)
cipher.rs:
- AES-CTR decrypt: payload Vec::with_capacity(payload_length)
Performance improvement:
- ~25% total improvement (Phase 1-3 cumulative)
- 100MB transfer: 1 second (~100 MB/s)
- 140x improvement from initial 712 KB/s
Test: 158 passed, 0 failed
2026-06-19 21:54:01 +08:00
Warren
bd89152e81
feat(ssh): Optimize SSH performance Phase 1-2c + stdin fix
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
Phase 1: take_payload() optimization
- cipher.rs: Added take_payload() to EncryptedPacket
- server.rs: Use take_payload() to avoid .to_vec() copy
Phase 2a: reuse_buf for CHANNEL_DATA
- channel.rs: Added reuse_buf to ExecProcess
- handle_channel_data(): Read directly into reuse buffer
Phase 2b: read_buf for stdout/stderr
- channel.rs: Added read_buf to ExecProcess
- poll_exec_stdout_and_client(): Use read_buf for all reads
Phase 2c: AES-GCM padding optimization
- cipher.rs: Removed padding .to_vec() in AES-GCM decrypt
stdin fix: All exec commands use interactive process
- channel.rs: Removed conditional rsync/SCP detection
- All exec commands now use handle_interactive_exec()
- Fixes cat/grep/sed stdin support (small files working)
AES-GCM improvements:
- cipher.rs: Added CipherMode enum (AES-GCM vs AES-CTR)
- cipher.rs: AES-256 key derivation (32 bytes)
- cipher.rs: Nonce format follows OpenSSH inc_iv()
- kex.rs: Added aes256-gcm@openssh.com to algorithms
Performance: ~21% improvement for small files
Test: 158 passed, 0 failed
Limitation: Large files (>10MB) not working yet (poll loop issue)
2026-06-19 20:18:20 +08:00
Warren
1650708ac7
Implement Phase 1 AES-GCM packet processing: AEAD encryption/decryption
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
Phase 1 complete implementation:
- AES-GCM AEAD encryption (EncryptedPacket::new)
- AES-GCM AEAD decryption (EncryptedPacket::read)
- AES-GCM packet structure: packet_length plaintext + ciphertext + 16-byte tag
- AES-GCM nonce: sequence_number (4 bytes -> 12 bytes)
- AES-CTR fallback preserved (MtE mode)
Key differences AES-GCM vs AES-CTR:
- AES-GCM: packet_length is plaintext (as AAD)
- AES-CTR: packet_length is encrypted
- AES-GCM: 16-byte GCM tag (no separate MAC)
- AES-CTR: 32-byte HMAC-SHA256 MAC
Performance improvement:
- AES-GCM: encrypt+authenticate in one step (AEAD)
- AES-CTR: MAC-then-Encrypt (2 steps)
Testing:
- OpenSSH client negotiated aes256-gcm@openssh.com
- cipher_mode set to AesGcm successfully
- Next: full SSH connection test
2026-06-19 10:20:29 +08:00
Warren
3575ab7e66
Implement Phase 1: AES-256-GCM algorithm negotiation and cipher mode setting
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
Performance optimization Phase 1 implementation:
- Add aes-gcm crate dependency (v0.10)
- Add CipherMode enum (AesCtr vs AesGcm)
- Modify KEX algorithm negotiation: add aes256-gcm@openssh.com
- Dynamic cipher mode setting based on KEX result
- Fix HMAC trait conflict with fully-qualified syntax
Strategy: Conservative approach
- Support AES-GCM algorithm negotiation (OpenSSH compatible)
- Dynamic cipher mode setting
- AES-CTR fallback preserved (packet processing unchanged)
Next steps:
- Test OpenSSH client AES-GCM negotiation
- Implement AES-GCM packet processing if needed
- Continue to Phase 4 (parallel encryption)
2026-06-19 10:10:53 +08:00
Warren
a235be312f
Fix duplicate route panic: Remove conflicting '/' route
2026-06-19 09:20:20 +08:00
Warren
00824df4ae
Update AGENTS.md: WebDAV VFS complete, protect Download Center
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
- Document WebDAV VFS integration status
- Add warning about not affecting Port 11438
- Revert WebDAV routes (temporarily) to protect Download Center
- WebDAV can be tested via CLI: webdav-start --port 8002
2026-06-19 09:12:37 +08:00
Warren
eb80c07c85
Implement WebDAV VFS integration: dav-server 0.11 compatible
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
- Add webdav.rs module: VfsDavFs, VfsDavFile, VfsDavMetaData
- Implement DavFileSystem + Clone for GuardedFileSystem blanket impl
- Add clone_boxed to VfsBackend trait (required for Sync)
- Update CLI webdav.rs to use VFS instead of SQLite
- Add bytes dependency
- All 155 tests pass
2026-06-19 08:19:16 +08:00
Warren
e2d58538f9
Implement Upload Hook for momentry integration (Phase 1)
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
- Add upload_hook.rs module: trigger video_probe + video_register on upload
- Add UploadHookSection to config: video extensions, binary paths
- Integrate with SFTP: handle_close triggers hook on write files
- Integrate with SCP/rsync: child process exit triggers hook
- All 155 tests pass
2026-06-19 06:26:20 +08:00
Warren
d94cb2df4c
Fix code quality: trailing whitespace, unused imports, clippy warnings
...
- Fix trailing whitespace in kex.rs and s3.rs
- Add missing KexProposal import in kex_complete.rs
- Auto-fix clippy warnings across all crates
- All 153 tests pass
2026-06-19 05:21:38 +08:00
Warren
963513ef0b
Add Security Audit Phase 9: comprehensive SSH security tests
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
- auth_security: password brute force, public key, user status, home dir
- crypto_security: AES-CTR, HMAC-SHA256, Curve25519, Ed25519
- file_access_security: path traversal, absolute path, symlink attack
- channel_security: window limits, request validation
- 18 new security tests, all pass (153 total)
2026-06-19 01:37:59 +08:00
Warren
ea156b65f1
Implement Web frontend Phase 2: Tab switching + search box UI
...
Test / build (push) Has been cancelled
Test / test (push) Has been cancelled
- New category_view.html with Apple-style design
- Tab switching between Category and Series views
- Search box with API integration
- Navigation stack for back button
- Routes: /downloads and / (root)
- All tests pass (135 passed)
2026-06-19 01:25:44 +08:00
Warren
dfd76738c9
Refactor sftp/server.rs: integrate DataProvider for authentication
...
Test / build (push) Has been cancelled
Test / test (push) Has been cancelled
- MarkBaseSftpServer now accepts Arc<dyn DataProvider>
- SshSession implements russh::server::Handler with auth_request
- Supports password and public key authentication via DataProvider
- Proper impl blocks structure (fix broken code)
- run_server() now takes DataProvider parameter
2026-06-19 01:13:23 +08:00
Warren
667d7209e2
Refactor sftp/auth.rs to use DataProvider trait
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
- SftpAuth now uses Arc<dyn DataProvider> instead of AuthDb
- Add verify_password(), get_user(), get_home_dir() methods
- Add unit tests for SftpAuth with SqliteProvider
- Maintain backward compatibility with existing tests
2026-06-19 01:06:02 +08:00
Warren
68472e0fb7
Fix all remaining test failures
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
- archive::metadata: add failed_files to test_extract_result
- archive::tests: use TempDir for validate_extraction_path test
- provider::sqlite: fix db path using CARGO_MANIFEST_DIR/../data/auth.sqlite
- ssh_server::cipher: use AES-128 key (16 bytes) in test
- ssh_server::kex_complete: set kexinit payloads in test
- ssh_server::rsync_handler: fix file list flags (use 1, not 0)
- ssh_server::sftp_handler: expect SSH_FXP_VERSION at byte 4 (after length prefix)
All 135 tests now pass
2026-06-19 00:48:53 +08:00
Warren
5c89b0e169
Fix test compilation errors: archive tests API updates + SSH tests
...
Test / build (push) Has been cancelled
Test / test (push) Has been cancelled
- archive/tests/mod.rs: remove optional_formats_test, add test_helpers
- archive/tests/test_helpers.rs: update zip/flate2/tar crate APIs
- archive/tests/core_formats_test.rs: restructure helper modules
- archive/processor.rs: add modified_time field, use actual_ratio()
- ssh_server/cipher.rs: add iv_ctos/iv_stoc to SessionKeys tests
- ssh_server/crypto.rs: make client_kex/server_kex mutable
- ssh_server/sshbuf.rs: fix mutable borrow conflict in test
Test result: 123 passed, 12 failed (assertion failures)
2026-06-19 00:25:31 +08:00
Warren
960ee87ce9
Add S3 VFS backend: VfsBackend impl for S3-compatible storage
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
- S3Vfs with all 15 VfsBackend methods via rusty-s3 + ureq
- S3VfsFile for buffered writes + ranged reads
- AWS Signature V4 pre-signed URLs (rusty-s3)
- ListObjectsV2 for directory listing (prefix + delimiter)
- Path-style URL mapping (/path to bucket/key)
2026-06-18 23:44:52 +08:00
Warren
f90e4f496c
VFS/DataProvider/Config refactoring + SSH public key authentication
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
Phase 1-6 of refactoring plan:
- VFS abstraction (VfsBackend trait + LocalFs + OpenFlags builder)
- DataProvider trait (SqliteProvider + PgProvider, SFTPGo-compatible)
- Config refactoring (AppConfig unified sections, env overrides)
- SSH handlers (sftp/scp/rsync) migrated to VFS + DataProvider
- SSH public key authentication (Ed25519 signature verification)
- SSH stderr → CHANNEL_EXTENDED_DATA support
- Web auth uses DataProvider instead of direct SQL
- User home directory from provider (per-user isolation)
- PostgreSQL auth provider for SFTPGo compatibility
2026-06-18 23:35:18 +08:00
Warren
83fb0de78a
Fix 5MB SFTP download hang: batch process SFTP packets + WINDOW_ADJUST chaining
...
Test / build (push) Has been cancelled
Test / test (push) Has been cancelled
Root cause: handle_channel_data processed only ONE SFTP packet per call,
leaving remaining batched packets stuck in the buffer. Client waited for
READ responses while server waited for more data — deadlock after ~3.1MB.
Fix:
- sftp_handler.rs: fix SSH_FXP_VERSION format (remove uint32 extension_count)
- sftp_handler.rs: fix handle_open error mapping (.ok() → build_status_from_io_error)
- channel.rs: batch-process ALL complete SFTP packets from buffer in loop
- channel.rs: add pending_packets VecDeque for multi-response queuing
- channel.rs: chain WINDOW_ADJUST + SFTP response when window is low
- channel.rs: add adjust_remote_window() for client WINDOW_ADJUST
- server.rs: drain pending_packets after each CHANNEL_DATA handler
Verified: 5MB upload + download with matching MD5
2026-06-18 17:15:00 +08:00
Warren
1d81db3af5
Enterprise-grade SFTP reliability improvements
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
- Remove all unwrap() calls from SftpAttrs::serialize() and from_metadata()
- Add extension advertisement in SSH_FXP_VERSION (10 extensions declared)
- Map std::io::ErrorKind to proper SSH_FX_* status codes (NotFound→FX_NO_SUCH_FILE etc.)
- Add restrict_absolute flag for chroot-like path confinement mode
- Add MAX_HANDLES limit (4096) to prevent handle exhaustion
- Add MAX_XFER_SIZE (1MB) and MAX_HASH_SIZE (256MB) OOM protection
- Fix test compilation errors (SftpHandler::new signature)
- Add build_status_from_io_error() helper for consistent error mapping
2026-06-18 06:42:33 +08:00
Warren
5344a7c16e
Fix rsync: Use real rsync subprocess instead of in-process handler
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
In-process RsyncHandler couldn't match openrsync protocol 29 flow
after version exchange. Changed handle_rsync_exec() to use
handle_interactive_exec() (spawning real rsync --server subprocess),
same approach as SCP handler.
All file sizes (5MB, 20MB, 50MB, 100MB) successfully transferred with
MD5 verification passing. Transfer speed ~712 KB/s limited by
AES-256-CTR encryption overhead.
2026-06-18 06:01:16 +08:00
Warren
664a3e1944
Phase 16.4: Fix SSH server crash - increase stdin timeout and poll iteration
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
修改内容:
- max_poll_iterations: 500 → 2000 (200秒)
- stdin timeout: 300 → 1500 iterations (150秒)
- 支持50MB+大文件传输
目的:
- 防止SSH server过早崩溃
- 给rsync足够时间处理数据
- 确保大文件传输稳定
测试验证:待完成(需重新测试50MB和100MB)
2026-06-17 23:08:37 +08:00
Warren
c80b3a8959
Phase 16.2.1: Performance optimization success - 26x speedup (20.46 MB/s)
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
修改内容:
- poll timeout: 10ms → 100ms
- max_poll_iterations: 5000 → 500
- log频率: 每10次 → 每50次
- stdin timeout: 3000 → 300 iterations (30s)
- ExecProcess添加command字段(用于SCP检测)
性能对比:
- Phase 15: 780 KB/s (24秒)
- Phase 16.2.1: 20.46 MB/s (1秒)
- **提升26倍** ⭐ ⭐ ⭐ ⭐ ⭐
测试结果:
- ✅ 传输速度: 接近AGENTS.md记录 (21-36 MB/s)
- ❌ 文件保存: server端文件不存在(待修复)
下一步:
- Phase 16.2.2: 修复rsync文件保存
- Phase 16.2.3: 增加Window size (16MB)
2026-06-17 22:28:36 +08:00
Warren
3595119941
Phase 16.1: Fix SCP stdin timeout (final analysis: abandon SCP legacy, recommend rsync)
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
修改内容:
- stdin timeout: 从500 iterations (5s) 改到3000 (30s)
- max_poll_iterations: 从1000改到5000 (50s)
- SCP完全禁用stdin timeout (is_scp_command检测)
测试结果:
- ❌ SCP 20MB失败 (只传输12MB, 400 KB/s)
- ✅ rsync 20MB成功 (MD5一致, 780 KB/s)
- 结论:SCP legacy protocol效率低,放弃SCP,推荐rsync
决策:方案3 - 放弃SCP legacy,推荐rsync (见phase16_1_scp_analysis.md)
下一步:Phase 16.2 - 性能优化 (提升780 KB/s到21-36 MB/s)
2026-06-17 22:25:39 +08:00
Warren
cacf106b80
Phase 4: Implement SSH packet size limit (maxpack - 1024)
...
Test / test (push) Has been cancelled
Test / build (push) Has been cancelled
- Add maxpack field to SftpHandler structure
- Modify SftpHandler::new() to accept maxpack parameter
- Limit SSH_FXP_READ data size to maxpack - 1024 bytes (OpenSSH style)
- Get maxpack from Channel.remote_maxpacket
Changes:
- sftp_handler.rs: SftpHandler struct + new() + handle_read()
- channel.rs: Pass remote_maxpacket to SftpHandler::new()
Reference: OpenSSH sftp-server.c: process_read()
- Limit: maxpacket - 1024 bytes
- Prevent packet size violation
Test status: 5MB upload still incomplete (2.0MB)
- Issue may require additional debugging
- Upload direction may also need maxpack limit
2026-06-17 20:18:21 +08:00