admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added a note about async testing style to contributing guide

Browse Source
This commit is contained in:
Steve Gravrock
2021-12-02 12:12:59 -08:00
parent d739c23401
commit 5eb42d67a7
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
.github/CONTRIBUTING.md vendored
View File

@@ -97,7 +97,12 @@ Or, How to make a successful pull request
without test-driving it. without test-driving it.
* _Write code in the style of the rest of the repo_ - Jasmine should look like * _Write code in the style of the rest of the repo_ - Jasmine should look like
a cohesive whole. a cohesive whole.
* **Exception**: Prefer `const` or `let` over `var`.
**Key exceptions:**
* Use `const` or `let` for new variable declarations, even if nearby code
uses `var`.
* New async specs should usually be async/await or promise-returning, not
callback based.
* _Ensure the *entire* test suite is green_ in all the big browsers, Node, and * _Ensure the *entire* test suite is green_ in all the big browsers, Node, and
ESLint. Your contribution shouldn't break Jasmine for other users. ESLint. Your contribution shouldn't break Jasmine for other users.