Check for accidental global variable creation

This commit is contained in:
Steve Gravrock
2018-03-25 12:01:50 -07:00
parent 7f1cdc2d02
commit 74287c578c
9 changed files with 26 additions and 8 deletions

View File

@@ -1,9 +1,17 @@
{
"bitwise": true,
"curly": true,
"globals": {
"clearTimeout": false,
"console": false,
"getJasmineRequireObj": true,
"jasmineRequire": true,
"setTimeout": false
},
"immed": true,
"newcap": true,
"trailing": true,
"loopfunc": true,
"quotmark": "single"
}
"quotmark": "single",
"undef": true
}

View File

@@ -21,6 +21,7 @@ OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
var getJasmineRequireObj = (function (jasmineGlobal) {
/* globals exports, global, module, window */
var jasmineRequire;
if (typeof module !== 'undefined' && module.exports && typeof exports !== 'undefined') {
@@ -704,6 +705,7 @@ getJasmineRequireObj().Spec = function(j$) {
};
if (typeof window == void 0 && typeof exports == 'object') {
/* globals exports */
exports.Spec = jasmineRequire.Spec;
}
@@ -1492,11 +1494,11 @@ getJasmineRequireObj().Env = function(j$) {
message += ': ';
if (error.message) {
message += error.message;
} else if (jasmine.isString_(error)) {
} else if (j$.isString_(error)) {
message += error;
} else {
// pretty print all kind of objects. This includes arrays.
message += jasmine.pp(error);
message += j$.pp(error);
}
}
@@ -1683,6 +1685,7 @@ getJasmineRequireObj().Any = function(j$) {
}
/* jshint -W122 */
/* global Symbol */
if (typeof Symbol != 'undefined' && this.expectedObject == Symbol) {
return typeof other == 'symbol';
}
@@ -1734,7 +1737,7 @@ getJasmineRequireObj().ArrayContaining = function(j$) {
};
ArrayContaining.prototype.jasmineToString = function () {
return '<jasmine.arrayContaining(' + jasmine.pp(this.sample) +')>';
return '<jasmine.arrayContaining(' + j$.pp(this.sample) +')>';
};
return ArrayContaining;
@@ -2114,6 +2117,7 @@ getJasmineRequireObj().clearStack = function(j$) {
getJasmineRequireObj().Clock = function() {
/* global process */
var NODE_JS = typeof process !== 'undefined' && process.versions && typeof process.versions.node === 'string';
/**
@@ -6037,6 +6041,7 @@ getJasmineRequireObj().Suite = function(j$) {
};
if (typeof window == void 0 && typeof exports == 'object') {
/* globals exports */
exports.Suite = jasmineRequire.Suite;
}

View File

@@ -1,5 +1,6 @@
getJasmineRequireObj().Clock = function() {
/* global process */
var NODE_JS = typeof process !== 'undefined' && process.versions && typeof process.versions.node === 'string';
/**

View File

@@ -736,11 +736,11 @@ getJasmineRequireObj().Env = function(j$) {
message += ': ';
if (error.message) {
message += error.message;
} else if (jasmine.isString_(error)) {
} else if (j$.isString_(error)) {
message += error;
} else {
// pretty print all kind of objects. This includes arrays.
message += jasmine.pp(error);
message += j$.pp(error);
}
}

View File

@@ -177,5 +177,6 @@ getJasmineRequireObj().Spec = function(j$) {
};
if (typeof window == void 0 && typeof exports == 'object') {
/* globals exports */
exports.Spec = jasmineRequire.Spec;
}

View File

@@ -163,5 +163,6 @@ getJasmineRequireObj().Suite = function(j$) {
};
if (typeof window == void 0 && typeof exports == 'object') {
/* globals exports */
exports.Suite = jasmineRequire.Suite;
}

View File

@@ -32,6 +32,7 @@ getJasmineRequireObj().Any = function(j$) {
}
/* jshint -W122 */
/* global Symbol */
if (typeof Symbol != 'undefined' && this.expectedObject == Symbol) {
return typeof other == 'symbol';
}

View File

@@ -19,7 +19,7 @@ getJasmineRequireObj().ArrayContaining = function(j$) {
};
ArrayContaining.prototype.jasmineToString = function () {
return '<jasmine.arrayContaining(' + jasmine.pp(this.sample) +')>';
return '<jasmine.arrayContaining(' + j$.pp(this.sample) +')>';
};
return ArrayContaining;

View File

@@ -1,4 +1,5 @@
var getJasmineRequireObj = (function (jasmineGlobal) {
/* globals exports, global, module, window */
var jasmineRequire;
if (typeof module !== 'undefined' && module.exports && typeof exports !== 'undefined') {