admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improved resolveValue/rejectValue error messages

Browse Source
This commit is contained in:
Elliot Nelson
2019-05-07 16:30:48 -04:00
parent 72aa0bbe4d
commit 95e1890e64
2 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spec/core/SpyStrategySpec.js
View File

@@ -112,9 +112,7 @@ describe("SpyStrategy", function() {
describe("#resolveValue", function() {
it("allows a resolved promise to be returned", function(done) {
if (!jasmineUnderTest.getPromise()) {
pending('Environment does not support promises.');
}
jasmine.getEnv().requirePromises();
var originalFn = jasmine.createSpy("original"),
spyStrategy = new jasmineUnderTest.SpyStrategy({fn: originalFn});
@@ -134,15 +132,13 @@ describe("SpyStrategy", function() {
expect(function() {
spyStrategy.resolveValue(37);
}).toThrowError('resolveValue is unavailable because the environment does not support promises.');
}).toThrowError('resolveValue requires global Promise, or a `promiseLibrary` configured with `jasmine.getEnv().configure()`');
});
});
describe("#rejectValue", function() {
it("allows a rejected promise to be returned", function(done) {
if (!jasmineUnderTest.getPromise()) {
pending('Environment does not support promises.');
}
jasmine.getEnv().requirePromises();
var originalFn = jasmine.createSpy("original"),
spyStrategy = new jasmineUnderTest.SpyStrategy({fn: originalFn});
@@ -162,7 +158,7 @@ describe("SpyStrategy", function() {
expect(function() {
spyStrategy.rejectValue(new Error('oops'));
}).toThrowError('rejectValue is unavailable because the environment does not support promises.');
}).toThrowError('rejectValue requires global Promise, or a `promiseLibrary` configured with `jasmine.getEnv().configure()`');
});
});

4
src/core/SpyStrategy.js
View File

@@ -94,7 +94,7 @@ getJasmineRequireObj().SpyStrategy = function(j$) {
var Promise = j$.getPromise();
if (!Promise) {
throw new Error('resolveValue is unavailable because the environment does not support promises.');
throw new Error('resolveValue requires global Promise, or a `promiseLibrary` configured with `jasmine.getEnv().configure()`');
}
this.plan = function() {
@@ -113,7 +113,7 @@ getJasmineRequireObj().SpyStrategy = function(j$) {
var Promise = j$.getPromise();
if (!Promise) {
throw new Error('rejectValue is unavailable because the environment does not support promises.');
throw new Error('rejectValue requires global Promise, or a `promiseLibrary` configured with `jasmine.getEnv().configure()`');
}
this.plan = function() {