admin/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check for and silence suite reentry warnings in Jasmine's own tests

Browse Source
This commit is contained in:
Steve Gravrock
2025-08-15 06:58:08 -07:00
parent 2299c85751
commit 98d5284c19
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spec/core/TreeProcessorSpec.js
View File

@@ -787,6 +787,7 @@ describe('TreeProcessor', function() {
runQueue runQueue
}); });
spyOn(jasmineUnderTest.getEnv(), 'deprecated');
processor.execute(); processor.execute();
const queueableFns = runQueue.calls.mostRecent().args[0].queueableFns; const queueableFns = runQueue.calls.mostRecent().args[0].queueableFns;
expect(queueableFns.length).toBe(5); expect(queueableFns.length).toBe(5);
@@ -831,6 +832,7 @@ describe('TreeProcessor', function() {
runQueue runQueue
}); });
spyOn(jasmineUnderTest.getEnv(), 'deprecated');
processor.execute(); processor.execute();
const queueableFns = runQueue.calls.mostRecent().args[0].queueableFns; const queueableFns = runQueue.calls.mostRecent().args[0].queueableFns;
expect(queueableFns.length).toBe(5); expect(queueableFns.length).toBe(5);

5
spec/core/integration/SpecRunningSpec.js
View File

@@ -621,9 +621,14 @@ describe('spec running', function() {
actions.push('spec3'); actions.push('spec3');
}); });
spyOn(jasmineUnderTest.getEnv(), 'deprecated');
await env.execute([spec2.id, spec3.id, spec1.id]); await env.execute([spec2.id, spec3.id, spec1.id]);
expect(actions).toEqual(['spec2', 'spec3', 'spec1']); expect(actions).toEqual(['spec2', 'spec3', 'spec1']);
expect(jasmineUnderTest.getEnv().deprecated).toHaveBeenCalledWith(
'The specified spec/suite order splits up a suite, running unrelated specs in the middle of it. This will become an error in a future release.'
);
}); });
it('refuses to re-enter suites with a beforeAll', async function() { it('refuses to re-enter suites with a beforeAll', async function() {