TESTS: Skipped tests should return -2

This commit is contained in:
Ronnie Sahlberg
2012-08-31 14:19:11 -07:00
parent 4df1525415
commit 09573068ad
25 changed files with 33 additions and 10 deletions

View File

@@ -115,6 +115,7 @@ int T0130_verify10_simple(const char *initiator, const char *url, int data_loss
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
scsi_free_scsi_task(vtask);
ret = -2;
goto finished;
}
if (vtask->status != SCSI_STATUS_GOOD) {

View File

@@ -118,6 +118,7 @@ int T0131_verify10_mismatch(const char *initiator, const char *url, int data_los
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
scsi_free_scsi_task(vtask);
ret = -2;
goto finished;
}
if (vtask->status == SCSI_STATUS_GOOD) {

View File

@@ -121,6 +121,7 @@ int T0132_verify10_mismatch_no_cmp(const char *initiator, const char *url, int d
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
scsi_free_scsi_task(vtask);
ret = -2;
goto finished;
}
if (vtask->status != SCSI_STATUS_GOOD) {

View File

@@ -96,6 +96,7 @@ int T0133_verify10_beyondeol(const char *initiator, const char *url, int data_lo
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (task->status != SCSI_STATUS_CHECK_CONDITION

View File

@@ -172,6 +172,7 @@ test2:
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (lbpws10) {

View File

@@ -110,6 +110,7 @@ int T0181_writesame10_unmap_unaligned(const char *initiator, const char *url, in
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (task->status == SCSI_STATUS_GOOD) {

View File

@@ -98,6 +98,7 @@ int T0182_writesame10_beyondeol(const char *initiator, const char *url, int data
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (task->status == SCSI_STATUS_GOOD) {

View File

@@ -96,6 +96,7 @@ int T0183_writesame10_wrprotect(const char *initiator, const char *url, int data
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (task->status == SCSI_STATUS_GOOD) {

View File

@@ -97,6 +97,7 @@ int T0184_writesame10_0blocks(const char *initiator, const char *url, int data_l
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (task->status != SCSI_STATUS_GOOD) {

View File

@@ -172,6 +172,7 @@ test2:
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (lbpws) {

View File

@@ -110,6 +110,7 @@ int T0191_writesame16_unmap_unaligned(const char *initiator, const char *url, in
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (task->status == SCSI_STATUS_GOOD) {

View File

@@ -97,6 +97,7 @@ int T0192_writesame16_beyondeol(const char *initiator, const char *url, int data
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (task->status == SCSI_STATUS_GOOD) {

View File

@@ -96,6 +96,7 @@ int T0193_writesame16_wrprotect(const char *initiator, const char *url, int data
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (task->status == SCSI_STATUS_GOOD) {

View File

@@ -97,6 +97,7 @@ int T0194_writesame16_0blocks(const char *initiator, const char *url, int data_l
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (task->status != SCSI_STATUS_GOOD) {

View File

@@ -115,6 +115,7 @@ int T0270_verify16_simple(const char *initiator, const char *url, int data_loss
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
scsi_free_scsi_task(vtask);
ret = -2;
goto finished;
}
if (vtask->status != SCSI_STATUS_GOOD) {

View File

@@ -118,6 +118,7 @@ int T0271_verify16_mismatch(const char *initiator, const char *url, int data_los
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
scsi_free_scsi_task(vtask);
ret = -2;
goto finished;
}
if (vtask->status == SCSI_STATUS_GOOD) {

View File

@@ -121,6 +121,7 @@ int T0272_verify16_mismatch_no_cmp(const char *initiator, const char *url, int d
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
scsi_free_scsi_task(vtask);
ret = -2;
goto finished;
}
if (vtask->status != SCSI_STATUS_GOOD) {

View File

@@ -85,6 +85,15 @@ int T0273_verify16_beyondeol(const char *initiator, const char *url, int data_lo
ret = -1;
goto finished;
}
if (task->status == SCSI_STATUS_CHECK_CONDITION
&& task->sense.key == SCSI_SENSE_ILLEGAL_REQUEST
&& task->sense.ascq == SCSI_SENSE_ASCQ_INVALID_OPERATION_CODE) {
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (task->status == SCSI_STATUS_GOOD) {
printf("[FAILED]\n");
printf("Verify16 command should fail when reading beyond end of device\n");
@@ -145,14 +154,6 @@ int T0273_verify16_beyondeol(const char *initiator, const char *url, int data_lo
ret = -1;
goto test2;
}
if (task->status == SCSI_STATUS_CHECK_CONDITION
&& task->sense.key == SCSI_SENSE_ILLEGAL_REQUEST
&& task->sense.ascq == SCSI_SENSE_ASCQ_INVALID_OPERATION_CODE) {
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
goto finished;
}
if (task->status == SCSI_STATUS_GOOD) {
printf("[FAILED]\n");
printf("verify16 command should fail when reading at LBA -1\n");

View File

@@ -115,6 +115,7 @@ int T0280_verify12_simple(const char *initiator, const char *url, int data_loss
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
scsi_free_scsi_task(vtask);
ret = -2;
goto finished;
}
if (vtask->status != SCSI_STATUS_GOOD) {

View File

@@ -29,7 +29,6 @@ int T0281_verify12_mismatch(const char *initiator, const char *url, int data_los
struct scsi_readcapacity16 *rc16;
int ret, i, lun;
uint32_t block_size;
uint64_t num_blocks;
printf("0281_verify12_mismatch:\n");
printf("=======================\n");
@@ -67,7 +66,6 @@ int T0281_verify12_mismatch(const char *initiator, const char *url, int data_los
goto finished;
}
block_size = rc16->block_length;
num_blocks = rc16->returned_lba;
scsi_free_scsi_task(task);
@@ -120,6 +118,7 @@ int T0281_verify12_mismatch(const char *initiator, const char *url, int data_los
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
scsi_free_scsi_task(vtask);
ret = -2;
goto finished;
}
if (vtask->status == SCSI_STATUS_GOOD) {

View File

@@ -121,6 +121,7 @@ int T0282_verify12_mismatch_no_cmp(const char *initiator, const char *url, int d
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
scsi_free_scsi_task(vtask);
ret = -2;
goto finished;
}
if (vtask->status != SCSI_STATUS_GOOD) {

View File

@@ -89,6 +89,7 @@ int T0283_verify12_beyondeol(const char *initiator, const char *url, int data_lo
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (task->status == SCSI_STATUS_GOOD) {

View File

@@ -123,6 +123,7 @@ int T0340_compareandwrite_simple(const char *initiator, const char *url, int dat
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (task->status != SCSI_STATUS_GOOD) {

View File

@@ -126,6 +126,7 @@ int T0341_compareandwrite_mismatch(const char *initiator, const char *url, int d
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (task->status == SCSI_STATUS_GOOD) {

View File

@@ -97,6 +97,7 @@ int T0343_compareandwrite_beyondeol(const char *initiator, const char *url, int
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
goto finished;
}
if (task->status == SCSI_STATUS_GOOD) {