admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

test-tool/test_prin_read_keys_truncate: Do not crash if PERSISTENT RESERVE IN fails

Browse Source 
Do not try to dereference the 'rk' pointer if it is NULL.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
This commit is contained in:
Bart Van Assche
2018-10-22 16:08:49 -07:00
parent ac9a8e5aed
commit a15c2a5c61
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
test-tool/test_prin_read_keys_truncate.c
View File

@@ -58,15 +58,17 @@ test_prin_read_keys_truncate(void)
}
CU_ASSERT_EQUAL(ret, 0);
/*
* SPC5r17: 6.16.2 READ KEYS service action
* The ADDITIONAL LENGTH field indicates the number of bytes in
* the Reservation key list. The contents of the ADDITIONAL
* LENGTH field are not altered based on the allocation length.
*/
CU_ASSERT_NOT_EQUAL(rk->additional_length, 0);
/* key array should have been truncated in the response */
CU_ASSERT_EQUAL(rk->num_keys, 0);
if (rk) {
/*
* SPC5r17: 6.16.2 READ KEYS service action
* The ADDITIONAL LENGTH field indicates the number of bytes in
* the Reservation key list. The contents of the ADDITIONAL
* LENGTH field are not altered based on the allocation length.
*/
CU_ASSERT_NOT_EQUAL(rk->additional_length, 0);
/* key array should have been truncated in the response */
CU_ASSERT_EQUAL(rk->num_keys, 0);
}
/* remove our key from the target */
ret = prout_register_key(sd, 0, key);