admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

TESTS: Remove the READ6 0-blocks test.

Browse Source 
Since you can not request a read for 0 blocks with READ6
this test makes no sense.
(transfer length ==0  means 256 blocks for READ6)
This commit is contained in:
Ronnie Sahlberg
2013-05-29 19:05:39 -07:00
parent 7b011a5ee2
commit b5a31571dc
4 changed files with 0 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Makefile.am
View File

@@ -230,7 +230,6 @@ bin_iscsi_test_cu_SOURCES = test-tool/iscsi-test-cu.c \
test-tool/test_prout_reserve_ownership.c \
test-tool/test_read6_simple.c \
test-tool/test_read6_beyond_eol.c \
test-tool/test_read6_0blocks.c \
test-tool/test_read10_simple.c \
test-tool/test_read10_beyond_eol.c \
test-tool/test_read10_0blocks.c \

1
test-tool/iscsi-test-cu.c
View File

@@ -173,7 +173,6 @@ static CU_TestInfo tests_prin_serviceaction_range[] = {
static CU_TestInfo tests_read6[] = {
{ (char *)"Read6Simple", test_read6_simple },
{ (char *)"Read6BeyondEol", test_read6_beyond_eol },
{ (char *)"Read6ZeroBlocks", test_read6_0blocks },
CU_TEST_INFO_NULL
};

1
test-tool/iscsi-test-cu.h
View File

@@ -104,7 +104,6 @@ void test_prout_reserve_ownership_wear(void);
void test_read6_simple(void);
void test_read6_beyond_eol(void);
void test_read6_0blocks(void);
void test_read6_rdprotect(void);
void test_read6_flags(void);

50
test-tool/test_read6_0blocks.c
View File

@@ -1,50 +0,0 @@
/*
Copyright (C) 2013 Ronnie Sahlberg <ronniesahlberg@gmail.com>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, see <http://www.gnu.org/licenses/>.
*/
#include <stdio.h>
#include <CUnit/CUnit.h>
#include "iscsi.h"
#include "scsi-lowlevel.h"
#include "iscsi-test-cu.h"
void
test_read6_0blocks(void)
{
int ret;
logging(LOG_VERBOSE, LOG_BLANK_LINE);
logging(LOG_VERBOSE, "Test READ6 0-blocks at LBA==0");
ret = read6(iscsic, tgt_lun, 0, 0, block_size, NULL);
if (ret == -2) {
logging(LOG_NORMAL, "[SKIPPED] READ6 is not implemented.");
CU_PASS("READ6 is not implemented.");
return;
}
CU_ASSERT_EQUAL(ret, 0);
if (num_blocks > 0x1fffff) {
CU_PASS("[SKIPPED] LUN is too big");
return;
}
logging(LOG_VERBOSE, "Test READ6 0-blocks one block past end-of-LUN");
ret = read6_lbaoutofrange(iscsic, tgt_lun, num_blocks + 1, 0,
block_size, NULL);
CU_ASSERT_EQUAL(ret, 0);
}