admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

TESTS: ReportSupportedOpcodes return the opcode itself as data[0], not 0xff

Browse Source 
The first byte of CDB USAGE FIELD contains the opcode value itself, not
0xff.

From SPC4 :
...
The first byte of the CDB USAGE FIELD
field shall contain the operation code for the command being queried.
...
This commit is contained in:
Ronnie Sahlberg
2014-02-24 19:04:58 -08:00
parent 0236395709
commit dbc9ffb5cb
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test-tool/test_report_supported_opcodes_one_command.c
View File

@@ -136,11 +136,15 @@ test_report_supported_opcodes_one_command(void)
logging(LOG_NORMAL, "[FAILED] CDB length is 0");
}
logging(LOG_VERBOSE, "Verify CDB[0] Usage Data is 0xFF");
CU_ASSERT_EQUAL(rsoc_one->cdb_usage_data[0], 0xff);
if (rsoc_one->cdb_usage_data[0] != 0xff) {
logging(LOG_NORMAL, "[FAILED] CDB[0] Usage Data is "
"not 0xFF");
logging(LOG_VERBOSE, "Verify CDB[0] Usage Data == <opcode>");
CU_ASSERT_EQUAL(rsoc_one->cdb_usage_data[0],
rsoc->descriptors[i].opcode);
if (rsoc_one->cdb_usage_data[0] != rsoc->descriptors[i].opcode) {
logging(LOG_NORMAL, "[FAILED] CDB[0] Usage Data was "
"0x%02x, expected 0x%02x for opcode 0x%02x",
rsoc_one->cdb_usage_data[0],
rsoc->descriptors[i].opcode,
rsoc->descriptors[i].opcode);
}
scsi_free_scsi_task(one_task);