admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Add tests for the WRPROTECT bits for WRITESAME10/16

Browse Source
This commit is contained in:
Ronnie Sahlberg
2012-06-23 21:40:58 +10:00
parent 124b71bd80
commit e7c8a173ab
6 changed files with 249 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile.am
View File

@@ -66,8 +66,10 @@ bin_iscsi_test_SOURCES = test-tool/iscsi-test.c \
test-tool/0170_unmap_simple.c test-tool/0171_unmap_zero.c \
test-tool/0180_writesame10_unmap.c test-tool/0181_writesame10_unmap_unaligned.c \
test-tool/0182_writesame10_beyondeol.c \
test-tool/0183_writesame10_wrprotect.c \
test-tool/0190_writesame16_unmap.c test-tool/0191_writesame16_unmap_unaligned.c \
test-tool/0192_writesame16_beyondeol.c \
test-tool/0193_writesame16_wrprotect.c \
test-tool/0200_read16_simple.c test-tool/0201_read16_rdprotect.c \
test-tool/0202_read16_flags.c test-tool/0203_read16_0blocks.c \
test-tool/0204_read16_beyondeol.c \

121
test-tool/0183_writesame10_wrprotect.c Normal file
View File

@@ -0,0 +1,121 @@
/*
Copyright (C) 2012 by Ronnie Sahlberg <ronniesahlberg@gmail.com>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, see <http://www.gnu.org/licenses/>.
*/
#include <stdio.h>
#include "iscsi.h"
#include "scsi-lowlevel.h"
#include "iscsi-test.h"
int T0183_writesame10_wrprotect(const char *initiator, const char *url, int data_loss _U_, int show_info)
{
struct iscsi_context *iscsi;
struct scsi_task *task;
struct scsi_readcapacity16 *rc16;
int ret, i, lun;
uint32_t block_size;
uint64_t num_blocks;
char buf[512];
printf("0183_writesame10_wrptotect:\n");
printf("=======================\n");
if (show_info) {
printf("Test that WRITESAME10 wrprotect\n");
printf("1, Write using WRPROTECT as non-zero\n");
printf("\n");
return 0;
}
iscsi = iscsi_context_login(initiator, url, &lun);
if (iscsi == NULL) {
printf("Failed to login to target\n");
return -1;
}
/* find the size of the LUN */
task = iscsi_readcapacity16_sync(iscsi, lun);
if (task == NULL) {
printf("Failed to send READCAPACITY16 command: %s\n", iscsi_get_error(iscsi));
ret = -1;
goto finished;
}
if (task->status != SCSI_STATUS_GOOD) {
printf("READCAPACITY16 command: failed with sense. %s\n", iscsi_get_error(iscsi));
ret = -1;
scsi_free_scsi_task(task);
goto finished;
}
rc16 = scsi_datain_unmarshall(task);
if (rc16 == NULL) {
printf("failed to unmarshall READCAPACITY10 data. %s\n", iscsi_get_error(iscsi));
ret = -1;
scsi_free_scsi_task(task);
goto finished;
}
block_size = rc16->block_length;
num_blocks = rc16->returned_lba;
scsi_free_scsi_task(task);
if (!data_loss) {
printf("--dataloss flag is not set. Skipping test\n");
ret = -1;
goto finished;
}
ret = 0;
/* Writesame10 with wrprotect */
printf("WRITESAME10 with WRPROTECT ... ");
for (i = 1; i <= 7; i++) {
task = iscsi_writesame10_sync(iscsi, lun, buf, block_size,
0, 1, 0, 0, 0, 0, i, 0);
if (task == NULL) {
printf("[FAILED]\n");
printf("Failed to send WRITESAME10 command: %s\n", iscsi_get_error(iscsi));
ret = -1;
goto test2;
}
if (task->status == SCSI_STATUS_GOOD) {
printf("[FAILED]\n");
printf("WRITESAME10 command should fail when WRPROTECT is set\n");
ret = -1;
scsi_free_scsi_task(task);
goto test2;
}
if (task->status != SCSI_STATUS_CHECK_CONDITION
|| task->sense.key != SCSI_SENSE_ILLEGAL_REQUEST
|| task->sense.ascq != SCSI_SENSE_ASCQ_INVALID_FIELD_IN_CDB) {
printf("[FAILED]\n");
printf("WRITESAME10 failed but with the wrong sense code. It should have failed with ILLEGAL_REQUEST/INVALID_FIELD_IN_CDB.\n");
ret = -1;
scsi_free_scsi_task(task);
goto test2;
}
scsi_free_scsi_task(task);
}
printf("[OK]\n");
test2:
finished:
iscsi_logout_sync(iscsi);
iscsi_destroy_context(iscsi);
return ret;
}

2
test-tool/0192_writesame16_beyondeol.c
View File

@@ -28,7 +28,7 @@ int T0192_writesame16_beyondeol(const char *initiator, const char *url, int data
int ret, i, lun;
uint32_t block_size;
uint64_t num_blocks;
char buf[512];
unsigned char buf[512];
printf("0192_writesame16_beyondeol:\n");
printf("=======================\n");

121
test-tool/0193_writesame16_wrprotect.c Normal file
View File

@@ -0,0 +1,121 @@
/*
Copyright (C) 2012 by Ronnie Sahlberg <ronniesahlberg@gmail.com>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, see <http://www.gnu.org/licenses/>.
*/
#include <stdio.h>
#include "iscsi.h"
#include "scsi-lowlevel.h"
#include "iscsi-test.h"
int T0193_writesame16_wrprotect(const char *initiator, const char *url, int data_loss _U_, int show_info)
{
struct iscsi_context *iscsi;
struct scsi_task *task;
struct scsi_readcapacity16 *rc16;
int ret, i, lun;
uint32_t block_size;
uint64_t num_blocks;
char buf[512];
printf("0193_writesame16_wrptotect:\n");
printf("=======================\n");
if (show_info) {
printf("Test that WRITESAME16 wrprotect\n");
printf("1, Write using WRPROTECT as non-zero\n");
printf("\n");
return 0;
}
iscsi = iscsi_context_login(initiator, url, &lun);
if (iscsi == NULL) {
printf("Failed to login to target\n");
return -1;
}
/* find the size of the LUN */
task = iscsi_readcapacity16_sync(iscsi, lun);
if (task == NULL) {
printf("Failed to send READCAPACITY16 command: %s\n", iscsi_get_error(iscsi));
ret = -1;
goto finished;
}
if (task->status != SCSI_STATUS_GOOD) {
printf("READCAPACITY16 command: failed with sense. %s\n", iscsi_get_error(iscsi));
ret = -1;
scsi_free_scsi_task(task);
goto finished;
}
rc16 = scsi_datain_unmarshall(task);
if (rc16 == NULL) {
printf("failed to unmarshall READCAPACITY16 data. %s\n", iscsi_get_error(iscsi));
ret = -1;
scsi_free_scsi_task(task);
goto finished;
}
block_size = rc16->block_length;
num_blocks = rc16->returned_lba;
scsi_free_scsi_task(task);
if (!data_loss) {
printf("--dataloss flag is not set. Skipping test\n");
ret = -1;
goto finished;
}
ret = 0;
/* Writesame16 with wrprotect */
printf("WRITESAME16 with WRPROTECT ... ");
for (i = 1; i <= 7; i++) {
task = iscsi_writesame16_sync(iscsi, lun, buf, block_size,
0, 1, 0, 0, 0, 0, i, 0);
if (task == NULL) {
printf("[FAILED]\n");
printf("Failed to send WRITESAME16 command: %s\n", iscsi_get_error(iscsi));
ret = -1;
goto test2;
}
if (task->status == SCSI_STATUS_GOOD) {
printf("[FAILED]\n");
printf("WRITESAME16 command should fail when WRPROTECT is set\n");
ret = -1;
scsi_free_scsi_task(task);
goto test2;
}
if (task->status != SCSI_STATUS_CHECK_CONDITION
|| task->sense.key != SCSI_SENSE_ILLEGAL_REQUEST
|| task->sense.ascq != SCSI_SENSE_ASCQ_INVALID_FIELD_IN_CDB) {
printf("[FAILED]\n");
printf("WRITESAME16 failed but with the wrong sense code. It should have failed with ILLEGAL_REQUEST/INVALID_FIELD_IN_CDB.\n");
ret = -1;
scsi_free_scsi_task(task);
goto test2;
}
scsi_free_scsi_task(task);
}
printf("[OK]\n");
test2:
finished:
iscsi_logout_sync(iscsi);
iscsi_destroy_context(iscsi);
return ret;
}

2
test-tool/iscsi-test.c
View File

@@ -72,11 +72,13 @@ struct scsi_test tests[] = {
{ "T0180_writesame10_unmap", T0180_writesame10_unmap },
{ "T0181_writesame10_unmap_unaligned", T0181_writesame10_unmap_unaligned },
{ "T0182_writesame10_beyondeol", T0182_writesame10_beyondeol },
{ "T0183_writesame10_wrprotect", T0183_writesame10_wrprotect },
/* writesame16*/
{ "T0190_writesame16_unmap", T0190_writesame16_unmap },
{ "T0191_writesame16_unmap_unaligned", T0191_writesame16_unmap_unaligned },
{ "T0192_writesame16_beyondeol", T0192_writesame16_beyondeol },
{ "T0193_writesame16_wrprotect", T0193_writesame16_wrprotect },
/* read16*/
{ "T0200_read16_simple", T0200_read16_simple },

2
test-tool/iscsi-test.h
View File

@@ -45,10 +45,12 @@ int T0171_unmap_zero(const char *initiator, const char *url, int data_loss, int
int T0180_writesame10_unmap(const char *initiator, const char *url, int data_loss, int show_info);
int T0181_writesame10_unmap_unaligned(const char *initiator, const char *url, int data_loss, int show_info);
int T0182_writesame10_beyondeol(const char *initiator, const char *url, int data_loss, int show_info);
int T0183_writesame10_wrprotect(const char *initiator, const char *url, int data_loss, int show_info);
int T0190_writesame16_unmap(const char *initiator, const char *url, int data_loss, int show_info);
int T0191_writesame16_unmap_unaligned(const char *initiator, const char *url, int data_loss, int show_info);
int T0192_writesame16_beyondeol(const char *initiator, const char *url, int data_loss, int show_info);
int T0193_writesame16_wrprotect(const char *initiator, const char *url, int data_loss, int show_info);
int T0200_read16_simple(const char *initiator, const char *url, int data_loss, int show_info);
int T0201_read16_rdprotect(const char *initiator, const char *url, int data_loss, int show_info);