admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

ISCSI fix leaked memory report

Browse Source 
As long as we have no struct iscsi_task we cannot track the
free() of data.indata buffer. This leads to a leaked memory
report in iscsi_context_destroy().

We fix this by assuming it has been freed when we pass it
it to scsi_task.

Signed-off-by: Peter Lieven <pl@kamp.de>
This commit is contained in:
Peter Lieven
2012-11-23 16:37:56 +01:00
parent 4a973e9a4e
commit f2f42547bd
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/iscsi-command.c
View File

@@ -377,6 +377,12 @@ iscsi_process_scsi_reply(struct iscsi_context *iscsi, struct iscsi_pdu *pdu,
}
}
/* the pdu->datain.data was malloc'ed by iscsi_malloc,
as long as we have no struct iscsi_task we cannot track
the free'ing of this buffer which is currently
done in scsi_free_scsi_task() */
if (pdu->indata.data != NULL) iscsi->frees++;
pdu->indata.data = NULL;
pdu->indata.size = 0;
@@ -511,6 +517,12 @@ iscsi_process_scsi_data_in(struct iscsi_context *iscsi, struct iscsi_pdu *pdu,
task->datain.data = pdu->indata.data;
task->datain.size = pdu->indata.size;
/* the pdu->indata.data was malloc'ed by iscsi_malloc,
as long as we have no struct iscsi_task we cannot track
the free'ing of this buffer which is currently
done in scsi_free_scsi_task() */
if (pdu->indata.data != NULL) iscsi->frees++;
pdu->indata.data = NULL;
pdu->indata.size = 0;