admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

test_writesame*_0blocks.c: Include WSNZ bit in test

Browse Source 
From the SBC-4 section about the block limits VPD page: "A write
same non-zero (WSNZ) bit set to one indicates that the device
server does not support a value of zero in the NUMBER OF LOGICAL
BLOCKS field in the WRITE SAME command CDBs (see 5.45, 5.46, and
5.47). A WSNZ bit set to zero indicates that the device server may
or may not support a value of zero in the NUMBER OF LOGICAL BLOCKS
field of the WRITE SAME commands." Hence verify that WRITE SAME
with NUMBER OF LOGICAL BLOCKS set to zero fails if WSNZ = 0.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
This commit is contained in:
Bart Van Assche
2014-03-05 10:42:01 +01:00
committed by Ronnie Sahlberg
parent cfce944b35
commit f6c4a82a22
2 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test-tool/test_writesame10_0blocks.c
View File

@@ -37,7 +37,8 @@ test_writesame10_0blocks(void)
}
logging(LOG_VERBOSE, LOG_BLANK_LINE);
logging(LOG_VERBOSE, "Test WRITESAME10 0-blocks at LBA==0");
logging(LOG_VERBOSE, "Test WRITESAME10 0-blocks at LBA==0 (WSNZ=%d)",
inq_bl->wsnz);
ret = writesame10(iscsic, tgt_lun, 0,
block_size, 0,
0, 0, 0, 0, NULL);
@@ -49,7 +50,11 @@ test_writesame10_0blocks(void)
} else if (ret == -4) {
CU_PASS("[SKIPPED] Number of WRITESAME10 logical blocks to be written exceeds MAXIMUM WRITE SAME LENGTH");
} else {
CU_ASSERT_EQUAL(ret, 0);
if (inq_bl->wsnz) {
CU_ASSERT_EQUAL(ret, -1);
} else {
CU_ASSERT_EQUAL(ret, 0);
}
}
logging(LOG_VERBOSE, "Test WRITESAME10 0-blocks one block past end-of-LUN");

9
test-tool/test_writesame16_0blocks.c
View File

@@ -32,7 +32,8 @@ test_writesame16_0blocks(void)
CHECK_FOR_SBC;
logging(LOG_VERBOSE, LOG_BLANK_LINE);
logging(LOG_VERBOSE, "Test WRITESAME16 0-blocks at LBA==0");
logging(LOG_VERBOSE, "Test WRITESAME16 0-blocks at LBA==0 (WSNZ=%d)",
inq_bl->wsnz);
ret = writesame16(iscsic, tgt_lun, 0,
block_size, 0,
0, 0, 0, 0, NULL);
@@ -45,7 +46,11 @@ test_writesame16_0blocks(void)
} else if (ret == -4) {
CU_PASS("[SKIPPED] Number of WRITESAME16 logical blocks to be written exceeds MAXIMUM WRITE SAME LENGTH");
} else {
CU_ASSERT_EQUAL(ret, 0);
if (inq_bl->wsnz) {
CU_ASSERT_EQUAL(ret, -1);
} else {
CU_ASSERT_EQUAL(ret, 0);
}
}
logging(LOG_VERBOSE, "Test WRITESAME16 0-blocks one block past end-of-LUN");