admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
918 Commits 1 Branch 0 Tags
bdce246bc0d3ce8f97bfafd9e348b0471d3fe4ad
Commit Graph

918 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ronnie Sahlberg
bdce246bc0 TESTS: Fix trying to free a NULL task. 2013-05-14 23:01:48 -07:00
Ronnie Sahlberg
e28a94ce77 TESTS: Add tests for WriteSame10/16 UNMAP. 
If UNMAP is available, verify that both LBPME and LBPWS[10] are set.
If unmap is not available, verify that LBPWS[10] is clear.
 2013-05-14 22:55:05 -07:00
Ronnie Sahlberg
dc6c603106 TEST: Add SCSI.Unmap.UnmapVPD and see if UNMAP availability matches 
the VPD settings.

If UNMAP is not available then LBPU must be clear
and if UNMAP is available then both LBPME and LBPU must be set.
 2013-05-14 22:35:57 -07:00
Ronnie Sahlberg
30358ffd56 TESTS: BlockLimits VPD. If a device returns a SBC-3 VPD (page length 0x3c) 
but does not claim SBC-3 support then print a harsh warning
about this.
 2013-05-14 20:43:09 -07:00
Ronnie Sahlberg
c7238aa426 TESTS: Relax the tests for BlockLimit VPD page length. 
Discussions on linux-scsi indicate that some SBC-2 devices may provide
some SBC-3 features and thus a SBC-3 BlockLimit page.

Supporting more than you claim is a transgression but a relatively minor
one, so lets turn a blind eye to it.
Supporting less than you claim is a serious transgression and will always
result in a harsh test failure.
 2013-05-14 20:37:20 -07:00
Ronnie Sahlberg
e9b79807ae TESTS: Make READCAPACITY16PI test more verbose under -V 2013-05-14 20:29:20 -07:00
Ronnie Sahlberg
dd46f3acf0 TESTS: Keep the LogicalBlockProvisioning VPD around after we read it during 
test startup.
 2013-05-14 20:25:42 -07:00
Ronnie Sahlberg
f49a1beb16 TEST: Add test for the protection information setting in READCAPACITY16 
If the device does not support PI (INQ->PROTECT) then
verify that PROT_EN, P_TYPE and P_I_EXP are all zero.

If the device does support PI and IF PROT_EN is clear
then verify that both P_TYPE and P_I_EXP are zero.

If the device does support PI and IF PROT_EN is set
then verify that P_TYPE is 0, 1 or 2
 2013-05-13 20:03:56 -07:00
Ronnie Sahlberg
f9fb1e0ee3 TESTS: ReadCapacity16 is also mandatory in SBC-2 when INQ->PROTECT is set. 
Check for this in the support functions and return error.
 2013-05-12 21:19:51 -07:00
Ronnie Sahlberg
d166d27ab8 TESTS: Add a test to start verifying that the BlockLimits VPD page is correct. 
Verify that the page length matches up with the size of the data in buffer.
Verify that page length is 0x3c if the device claims SBC-3,  and 0x0c if not.

If the device claims SBC-3 and if it claims UNMAP support (LBPU)
then we check that both MAXIMUM UNMAP LBA COUNT and
MAXIMUM UNMAP BLOCK DESCRIPTOR COUNT looks sane.
Sane here means >0, <1M or 0xffffffff

If the device claims SBC-3 and if it does not claim UNMAP support (LBPU)
then we check that both MAXIMUM UNMAP LBA COUNT and
MAXIMUM UNMAP BLOCK DESCRIPTOR COUNT are both 0.
 2013-05-12 18:43:43 -07:00
Ronnie Sahlberg
704e0f6448 SCSI: add a safe function to read a byte from the datain buffer and use it 
throughout the unmarshalling code
 2013-05-12 13:57:15 -07:00
Ronnie Sahlberg
bd239db4fa TEST: Add a test for inquiry version descriptors 
Block devices should claim at least some version of SPC and SBC
 2013-05-12 08:26:21 -07:00
Ronnie Sahlberg
ee689ee3fb TESTS: Update the protection tests 2013-05-12 08:06:08 -07:00
Ronnie Sahlberg
67676d4756 TESTS: *protect field set to non-zero are only guaranteed to fail if the device does not support protection information 2013-05-11 17:27:35 -07:00
Ronnie Sahlberg
5135836ee5 TESTS: keep the unmarshalled std inq structure around 2013-05-11 17:07:59 -07:00
Ronnie Sahlberg
772d220217 Add a version descriptor 2013-05-11 16:03:23 -07:00
Ronnie Sahlberg
3a31759fa4 Merge pull request #62 from bonzini/master 
MD5 updates
 2013-05-03 06:36:35 -07:00
Paolo Bonzini
bcb2950d8d use libgcrypt for MD5 
This makes sure that CHAP authentication is disabled if the system
is running in FIPS 140-2 mode.  MD5 is not a secure algorithm according
to the standard.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
 2013-05-03 12:51:15 +02:00
Paolo Bonzini
cc742279d0 fix bug in md5 code 2013-05-03 12:50:58 +02:00
Ronnie Sahlberg
d38cf7cfcd TESTS: since we track expcmdsn we dont need to keep the old value around in a static variable 2013-04-30 19:17:59 -07:00
Ronnie Sahlberg
b7dd6b533b TEST: Add a test that is cmdsn is too low the target just ignores the pdu 2013-04-30 19:05:23 -07:00
Ronnie Sahlberg
325360789e TEST: Improve the test for cmdsn too high with more documentation 
and verify that the target did ignore the command and the session is still good.
 2013-04-30 18:46:26 -07:00
Ronnie Sahlberg
1a275bbecc TEST: rename the cmdsn too high test 2013-04-30 18:32:09 -07:00
Ronnie Sahlberg
1165e06d19 Fix a bunch of typos 2013-04-29 21:02:40 -07:00
Ronnie Sahlberg
4a8d967541 Add support for synchronous command timeout. 
Default to 0 meaning no timeout.

Implement a test for iSCS to test what happens if we send a command
with CMDSN being higher than the target allows.
In this case we dont strictly know what will happen, just that what should
NOT happen is the target responding with success.
But we have to be prepared for any kind of failure, including a timeout,
scsi sense, or even iscsi reject or session failure.
 2013-04-29 20:42:33 -07:00
Ronnie Sahlberg
5bce69f1f3 TEST: rename the usb block device tests to usb-sbc 2013-04-27 20:39:30 -07:00
Ronnie Sahlberg
f8e317c355 TESTS: READ6 is optional(==obsolete) 2013-04-27 16:22:58 -07:00
Ronnie Sahlberg
94d048afae TESTS: Persistent reserve in/out are optional 2013-04-27 14:09:19 -07:00
Ronnie Sahlberg
4222d5fcd7 TESTS: Add another level for the test hiearchy : Familt/Suite/Test 
and add 4 basic families :  ALL, SCSI, iSCSI and USB-MEMORY-STICK
 2013-04-27 13:57:57 -07:00
Ronnie Sahlberg
9d44644c63 TESTS: Move the tests for iscsi residuals to its own suite 2013-04-27 10:15:30 -07:00
Ronnie Sahlberg
2627a8845e TESTS: add a flag --usb so we can clamp all i/o to at most 120k 
Add checks for maximum tranfer length to all commands that are limited
by BlockLimits/MTL
 2013-04-27 09:59:59 -07:00
Ronnie Sahlberg
c866787dcb TESTS: read12 is optional, should make test skip, not fail 2013-04-27 07:43:24 -07:00
Ronnie Sahlberg
227489d32b TESTS: fix PREFETCH10/16 tests 2013-04-26 18:01:04 -07:00
Ronnie Sahlberg
1331656f85 TESTS: ORWRITE is optional, lack os support should skip the test not fail it 2013-04-26 17:52:55 -07:00
Ronnie Sahlberg
78e02737c6 TESTS: fix some bugs in the tests for INQUIRY 2013-04-26 17:43:06 -07:00
Ronnie Sahlberg
e33194d94a TESTS: WRITEVERIFY10/12/16 are all optional. 
Update the helpers to return -2/not supported on invalid operaction code.
Update all tests to accept that the opcode might be missing and abort the test without failing.
 2013-04-25 17:41:13 -07:00
Ronnie Sahlberg
b5804ee499 TESTS: Update WRITE10/12 to allow it to fail with invalid operation code. Both these opcodes are Optional in all SBC standards. 2013-04-23 21:29:25 -07:00
Ronnie Sahlberg
ee666ae451 TESTS: WRITE16 is optional so update the tests to allow WRITE16 to be missing and just make the test be [SKIPPED] 2013-04-23 21:15:28 -07:00
Ronnie Sahlberg
d280ce8ad7 Create safe 16/32/64 bit accessors for reading from the datain buffer 
and use it throughout the scsi lowlevel file.

We probably want a safe accessor for byte access to at some stage.
 2013-04-22 22:11:53 -07:00
Ronnie Sahlberg
0a026e2da7 AROS: We need emulation of readv/writev on aros 2013-04-22 18:50:05 -07:00
Ronnie Sahlberg
322be0cf24 add missing version descriptor 2013-04-22 18:34:02 -07:00
Ronnie Sahlberg
555906e76e Revert "Add SSC to the version descriptors." 
This reverts commit 45f5fc2105.

Conflicts:

	include/scsi-lowlevel.h
 2013-04-22 18:32:09 -07:00
Ronnie Sahlberg
e640fa3cde missing , broke compile 2013-04-22 18:28:20 -07:00
Ronnie Sahlberg
45f5fc2105 Add SSC to the version descriptors. 
I actually have a usb-stick that claims it supports SSC. I stongly doubt it.
 2013-04-22 17:44:13 -07:00
Ronnie Sahlberg
284514b14e fix typo 2013-04-22 17:38:10 -07:00
Ronnie Sahlberg
79f54c5e06 TESTS update all read16 tests to fail/skip on illegal opcode depending on whether the device claims support for it or not (mandatory in sbc-3, optional prior) 2013-04-22 17:31:50 -07:00
Ronnie Sahlberg
77ff1b1808 TESTS: make the "is readcapacity16 supported on this device" tests cleaner 2013-04-22 17:11:38 -07:00
Ronnie Sahlberg
af6d1c9c13 Add a test for mandatory opcodes for SBC devices. 
Note that Read16/Readcapacity16 are mandatory on SBC3 but not prior.
Not all mandatory opcodes are tested for yet.
 2013-04-21 14:50:41 -07:00
Ronnie Sahlberg
91a98d6b92 Add handling of inquiry version descriptors 2013-04-21 14:04:30 -07:00
Ronnie Sahlberg
b3ca40efbe Get rid of the popt dependency 2013-04-21 10:25:30 -07:00